Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] --cert-reqs option could be more descriptive #1198

Closed
mtourne opened this issue Feb 4, 2016 · 3 comments · Fixed by #2634
Closed

[doc] --cert-reqs option could be more descriptive #1198

mtourne opened this issue Feb 4, 2016 · 3 comments · Fixed by #2634

Comments

@mtourne
Copy link

mtourne commented Feb 4, 2016

Documentation is not super explicit on --cert-reqs

I was trying --certs-reqs 1 for a while and thinking it wasn't working as expected.
I had to read the code to understand that the value is passed straight into SSLContext.verify_mode, and that '1' didn't mean "turn on client cert validation" but instead codes for : ssl.CERT_OPTIONAL

--cert-reqs 2 (which is the value for ssl.CERT_REQUIRED) did the trick.

@berkerpeksag
Copy link
Collaborator

+1 Actually, the entire SSL section needs a bit of clarifying :) Would you like to send a pull request?

@benoitc
Copy link
Owner

benoitc commented May 2, 2016

@berkerpeksag what do we need exactly?

@tilgovi
Copy link
Collaborator

tilgovi commented May 2, 2016

@benoitc I think we should support the symbolic constants, since they are a small, fixed, finite set of values, and we should clarify the documentation.

@benoitc benoitc added this to Other in Mailing List Feb 26, 2017
@benoitc benoitc added this to SSL Issues in Improve SSL UX Nov 22, 2019
@benoitc benoitc removed this from Other in Mailing List Nov 22, 2019
@benoitc benoitc added this to the 20.1 milestone Nov 22, 2019
@benoitc benoitc removed this from the 20.1 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Improve SSL UX
  
To DO
Development

Successfully merging a pull request may close this issue.

4 participants