docs: add examples for cert-reqs #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1198
I spent quite a lot of time to figure out what flag/validator value I should use for
cert-reqswhen I was trying to make the client verification optional - the request can be accepted by my server regardless the client provides a certificate or not. During the research process, I find the SSL section of the documentation could use some improvement here as new users like me would not be able to think of which number (0, 1, 2) stands for which verification mode on the spot.I find an open issue #1198 raised in 2016 mentioning the same ambiguity about the
cert-reqsflag in the docs that I am also facing. There wasn't a PR raised back then, so I am raising this one to address this issue now.