Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the best available reloader when --reload is passed #1430

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Use the best available reloader when --reload is passed #1430

merged 1 commit into from
Feb 6, 2017

Conversation

berkerpeksag
Copy link
Collaborator

Fixes #1422

@mark-adams
Copy link
Contributor

The biggest problem that I see with this change is that the preferred_reloader may not always be desirable. For instance, inotify may be supported by the OS but not by the underlying filesystem. In that case, the library would try to use inotify but would never receive notification of changes because the filesystem driver doesn't support inotify. Currently, the user could simply force polling via the --reload argument and they'd be good to go. With this change, they'd be out of luck and the reloader wouldn't work.

@berkerpeksag berkerpeksag merged commit 577c3eb into benoitc:master Feb 6, 2017
@berkerpeksag berkerpeksag deleted the revert-reload branch February 6, 2017 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants