Add some lint errors to .pylintrc disable list (#2123)

[hramezani]

Fixes #2123

[berkerpeksag]

Thanks for the PR! I don't think any of these pylint errors make our code better. I'd prefer adding them to the ignore list at https://github.com/benoitc/gunicorn/blob/master/.pylintrc#L13

[hramezani]

@berkerpeksag I have added them to .pylintrc disable section.

[Djailla]

Except for import-outside-toplevel I find the warning pretty useful.

Especially for module, xxx = module, yyy which add no value here.

For the no else after break, it make the code more compact and avoid big if / else.

IMO only import-outside-toplevel should be in pylintrc

[hramezani]

@Djailla I agree with you.
@berkerpeksag What do you think?

[hramezani]

I added import-outside-toplevel to pylintrc disable list and fixed the rest of lint errors.

[tilgovi]

Thank you!

[benoitc]

I don't unrstand some changes in the reloader and gthread worker. how are they related? and what do they fix?

I mean the else in gthread is here for readability. this ˋif` may be enough but the logic is not explicit.

About the ˋcontinue` removal in the reloader module it follows the same logic and is more optimized (it continue the loop now and after evaluating the other sentences)

[hramezani]

@benoitc I can revert the change gthread and reloader modules and add no-else-continue and no-else-break to pylintrc disable list.
It is okay for you?

[tilgovi]

I'm neutral. I like using defaults for linters, rather than doing lots of customization. I also like some of these rules, some of the time.

For example, I really like when guards near the top of functions are under if, without an else:

def foo():
    if guard:
        return

    # no else because this is not about one thing _or_ the other, just about a precondition

It's rare that I find these lint rules to make the code worse, and if it does it can be locally disabled.

I'm 👍 for these changes the way they are in this PR right now.

[benoitc]

i'm agree with the general spirit. Although in this two cases, yes, I would prefer to keep it the current way. It's more readable. Rest of the patch is OK, thanks for this.

There is a bunch of refactoring that could be done later to modernize the current source but let's not all the warnings dictate all of it for now :)

[hramezani]

pylint: disable=no-else-break added to workers/gthread.py
pylint: disable=no-else-continue added to reloader.py

[benoitc]

thanks!