-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update faq.rst and fix technical mistake on ulimit #2173
Conversation
Nice! I'm not sure the "using sudo" sentence is necessary. The recommendation is very clear! It might also be good to add a note about the Should we try to recommend any reading about |
@tilgovi Yes you are right, modifying limits.conf or using systemd unit file are also correct way besides. I don't want to talk about external dependencies just now, just want to focus on the problem itself, so I gave my word in this PR. Maybe other words are better. Sorry for my poor English. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ulimit would definitely work for a terminal and some users so I would make the line added as a warning note to highlight it.
No, it should not work. |
You may check it in /proc//limits |
i did't mean to keep the sudo. i know what ulimit is about.
On Mon 18 Nov 2019 at 13:17 REN Xiaolei ***@***.***> wrote:
No, it should not work.
ulimit is a built-in command of shell, it take effect only in the shell
and its children processes.
sudo ulimit would run setrlimit() in a sudo process, and then return.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2173?email_source=notifications&email_token=AAADRISRQXHX7OHHF3UDMADQUKBULA5CNFSM4JNFIMJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKH5OA#issuecomment-554991288>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADRIQDDELDBXJLMM2TOVTQUKBULANCNFSM4JNFIMJA>
.
--
Sent from my Mobile
|
OK, I'll change the PR later. I need some time to consider how to express this. |
hrm i just meant to ass the warning tag in the restdoc :)
On Mon 18 Nov 2019 at 13:25 REN Xiaolei ***@***.***> wrote:
OK, I'll change the PR later. I need some time to consider how to express
this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2173?email_source=notifications&email_token=AAADRIQE5M3JHVJLYRHCFZLQUKCSLA5CNFSM4JNFIMJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKISBA#issuecomment-554993924>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADRITYSI3U7IPENZXTJFLQUKCSLANCNFSM4JNFIMJA>
.
--
Sent from my Mobile
|
warning tag in FAQ's ulimit paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the .. warning:: must be related to the paragraph, see my comment inline.
No description provided.