Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate and parameterize exit error logging. #3057

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

De-duplicate and parameterize exit error logging. #3057

wants to merge 3 commits into from

Commits on Aug 17, 2023

  1. De-duplicate and parameterize exit error logging. 

    The signal log message had the PID and signal in the message format string,
which makes each message unique. This is awkward in log processing with for
example Sentry, where you want to see similar messages grouped together.

The exit message was emitted twice, from the "if exitcode != 0" and
the "if exitcode > 0" clause. You would be seeing things like:

[2023-08-17 09:50:10 +0200] [66450] [ERROR] Worker (pid:66451) exited with code 1
[2023-08-17 09:50:10 +0200] [66450] [ERROR] Worker (pid:66451) exited with code 1.
    @jeroenpulles
    jeroenpulles committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    2df26c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge remote-tracking branch 'origin/master' into log-errors

    @jeroenpulles
    jeroenpulles committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d4641cb View commit details
    Browse the repository at this point in the history

  2. reorganize the log handling in arbiter's reap workers method.

    @jeroenpulles
    jeroenpulles committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    baea1c8 View commit details
    Browse the repository at this point in the history