Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: minimal dependency versions: specify them and try them in CI #3134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CI: minimal dependency versions: specify them and try them in CI #3134

wants to merge 3 commits into from

Conversation

pajod
Copy link
Contributor

@pajod pajod commented Dec 29, 2023 •
edited

We should know our minimum versions, and possibly how they are different depending on python version, e.g. see #2675

This is not the change in minimal dependencies, this is just the necessary duplication (pypa/pip#8085) and hooking it up to GitHub CI. Has everything added as comments though, so after this one is merged, any future PR actually bumping dependencies could have that extra ✅/❌ show up.

The useless header/comment line swap is intentional, works around a bug in GitHub diff syntax highlighting.

@pajod pajod force-pushed the patch-mindep branch 2 times, most recently from ea460e0 to 290edb4 Compare February 19, 2024 05:13
@pajod pajod mentioned this pull request Apr 26, 2024
Open
11 tasks
pajod added 2 commits May 14, 2024 21:20
@pajod
CI: test pybuild-plugin-pyproject
cd17889
@pajod
CI: exclude CI info from source tarballs
0eeae5c 
Debian-style packaging procedures generally want to add their own debian/ folder on top of orig.tar.gz

Note the overlap:

 * .gitattributes specifies what git-committed are to be ignored for git archive
 * MANIFEST.in specifies what python build places into sdist

One way to remove this overlap is deferring both decisions to the one git source of truth, e.g. by using setuptools-scm.
@pajod
Copy link
Contributor Author

pajod commented May 14, 2024

Attached further patches:

  • CI should verify that whatever changes and workarounds are applied by debhelper do not break building
    • the best way to do that would be to add Debian metadata and call dpkg-buildpackage -us -uc
      • note: Debian metadata used for this purpose shall not end up in source tarballs
    • this one is not quite complete, as I have not been able to instruct setuptools 59.6.0 (from 2021) to read our toml-format metadata, so the CI job falls back to copying a minimal cfg-format to at least try the remaining steps
  • CI should verify that python -m build works
    • whether that is done for publishing on a regular basis or not, using the pypi-provided github action seems reasonable
      • DANGER this is prepared in my patch, but partly commented out as it is non-obvious how to structure the CI configuration without running into one of the "oops, everyone with permission to open PR has write access" traps GitHub has conveniently laid out

@pajod pajod changed the title CI: verify minimal dependency versions CI: minimal dependency versions: specify them and try them in CI May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pajod