-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add type annotations and rework some None/unset/default cases #3201
Draft
pajod
wants to merge
10
commits into
benoitc:master
Choose a base branch
from
pajod:patch-mypy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermit reloader without public tracebacks
this simply forces the specific test to work. much more work to be done to properly unbreak.
pajod
commented
May 21, 2024
raise ValueError("Invalid header map behaviour: %s" % val) | ||
|
||
|
||
class OnFatal(Setting): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming pattern clash. Sounds like Server Hook but is not implemented as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we can ship type annotations in separate
*.pyi
files right now, with no need to await dropping 3.7 compat and no obvious harm to people that have no use for them. Reworking #2377 I ended up with a certainly still imperfect, but already somewhat useful set of annotations. A few default settings in gunicorn popped out as odd:--config=""
does not disable reading configuration. the next best thing, setting--config=/dev/null
loudly complains--reload
has non-obvious side-effects in error handling, and setting--reload-extra=
is silently ignored when set in isolationself
method arg.docs/gunicorn_ext.py
to keep documentation unaffectedgid = abs(gid) & 0x7FFFFFFF
<= now unnecessary and broken for systems that actually use group id > 2**32 (see gunicorn/util.py set_owner_process Mangling gid on RHEL8 + Google Cloud Platform (very large int group id) #3212)gevent_pywsgi
worker class (but this was already noticed independently, see Access log formatting is wrong when using gevent_pywsgi worker class #2940)This is primarily an invitation to discuss potential default settings changes, the attached patches serve as clarification.
Advantages of shipping type annotations:
Disadvantages of shipping type annotations:
Related
Fixes: #2833 #2374 #1393