773-sigill-introspection #793
Conversation
| tempdir = util.gettempdir(self.cfg) | ||
| now = datetime.now() | ||
| time_stamp = now.strftime('%Y%m%d%H%M%S') | ||
| file_path = ("%s/gunicornsigill_%s_%s" % (tempdir, time_stamp, self.pid)) |
There was a problem hiding this comment.
I know we are using a POSIX system, but could you use os.path.join ? thanks
There was a problem hiding this comment.
This is fixed, thanks for the hint.
|
@tkornai I really like the idea. But by default gunicorn shouldn't rely on greenlets and use anything available on Python to do the job first. I understand why you're using the greenlets though. Imo we should isolate the usage of greenlets for eventlet and gevent. (@tilgovi btw i don't hink we are using the async module for anything other than these two workers, maybe we should rename it?) . And find a way for the others workers based on asyncio and tornado. Would be cool if you can rework the patch in that direction :) Let me know if you have any question.
|
|
Hi @benoitc - I've removed the greenlet dependency from sync and base. My feeling is that it's ok to move it to async as currently there is no worker based on async that does not require greenlet. I think introducing a new GreenletWorker at this point would be overengineering and can wait until such an async worker is added which does not depend on greenlet. Unfortunately I'm not familiar with tornado so I don't really know how to tackle that case. |
|
Hi @benoitc I just wanted to pick up on this issue. Let me know if you need further changes on my side or what else would be required to push this further. Thanks, |
|
Thank you for the proposal and the patch, we need to discuss about some points, but we will come back to you with a response or a merged branch |
|
actually i wonder if we couldn't rename the worker async as gsync for greenlets sine async is mostly used for eventlet and gevent workers. (need to check with meinheld). Or maybe better to find a way to abstract such call so we could override it in gevent and eventlet workers. I am still undecided if it's OK to use the greenlet module directly in the async module. cc @tilgovi |
|
I only know about meinheld. We could probably change it without too much disruption. +1 for gsync or green or whatever you think it best. |
|
Only keep async if it can share code between greenlet and other asynchronous workers. |
|
closing since there are no activity since 2 years. |
#773
This feature is intended to help analyse the state of gunicorn processes in a given point of time. This can come handy when dealing with performance issues.
A new signal handler for SIGILL would be introduced which triggers the status dump. When the signal is received workers dump their current requests with stack traces to the /tmp dir. If the signal is sent to the master it will broadcast it to its workers.