Support loading config from module

[graingert]

No description provided.

[graingert]

This allows configuration with gunicorn -c project.gunicorn_config rather than

gunicorn -c `python -c "print(__import__('project.gunicorn_config').__file__)"`

This is useful as in general all python code should be deployed using setuptools/distutils packages to gain the advantages of eggs, zips and wheels. Unfortunately this results in the indeterminate location of python files.

I'd like to move to deprecate loading from files to greatly simplify the code.

[benoitc]

Thanks for the patch :)

Although it looks like a duplicate from #789 did you actually tested the latest master? Is something missing?

[graingert]

@benoitc this is different from #789 in that here we load a module rather than a path to a py or pyc file.

[benoitc]

rather than importing import_lib, it should use the import_module function in gunicorn.util to make it compatible with old versions.

[benoitc]

@graingert OK I see. And just commented ;)

[graingert]

I will add documentation if this patch adds desired behaviour :)

[berkerpeksag]

Could you add a test to https://github.com/benoitc/gunicorn/blob/master/tests/test_003-config.py?

[graingert]

@berkerpeksag how's that https://github.com/benoitc/gunicorn/pull/799/files#diff-fd7a8bf53cc6acf524f9ed1e41d2fc8cR190?

[benoitc]

+1 for the change.

[graingert]

Added documentation

[berkerpeksag]

LGTM.

[tilgovi]

Good patch, but does it make sense to try filename before modules instead of the other way around? That would be more consistent with the normal importer (local relative then global modules), no?

[benoitc]

@tilgovi +1 we should switch the order