-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't install gaiohttp if python < 3.3 #801
Conversation
Looks like you're not collecting from the tests/ directory. |
Yes, I don't include tests/ and examples/ in list of installed modules -- they are not included for now also:
|
@benoitc please review |
Derp. My bad. I was just skimming to check that it wasn't a behavior change and misread exclude as include. +1 |
@davisp no problem, thanks. |
+1 LGTM |
Don't install gaiohttp if python < 3.3
Done! |
So now pypi package does not contain gaiohttp.py file, resulting in
|
@nicorevin thanks for the feedback, working on it in #830 . I will make a new release later today. |
See #788
That prevents syntax warning on library installation step.
The patch enumerates all python modules directly without handy autodiscovery (
setuptools.find_packages
).It still uses setuptools for making console scripts etc, I don't think that we need to remove it.