close half-closed socket to avoid leak #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitc
added a commit
that referenced
this pull request
Aug 20, 2015
close half-closed socket to avoid leak
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #230
inet:peername/1returns{error, enotconnect}against half-closed sockets. so they should be closed here.we make millions of http requests per minute and get few socket leak. It is very rare case and hard to reproduce.
but when someone checkin a socket to the pool, e.g. it means " I release the ownership of it. I will never read, write and CLOSE it." , so it is sane for hackney_pool to close the half-closed socket here.