Convert to Python3 #144
Open
Convert to Python3 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ | |||
| $Id$ | |||
| """ | |||
|
|
|||
| import os, shutil, sys, tempfile, urllib2 | |||
| import os, shutil, sys, tempfile, urllib.request, urllib.error, urllib.parse | |||
There was a problem hiding this comment.
Add following script shall make it python2/3 compatible
# Python 2 and 3: alternative 4
try:
from urllib.parse import urlparse, urlencode
from urllib.request import urlopen, Request
from urllib.error import HTTPError
except ImportError:
from urlparse import urlparse
from urllib import urlencode
from urllib2 import urlopen, Request, HTTPError
|
btw, did you communicate with the maintainer before undertaking this massive conversation? |
|
where is gone the PR?
…On Sun, May 21, 2017 at 1:47 PM Ronny Pfannschmidt ***@***.***> wrote:
btw, did you communicate with the maintainer before undertaking this
massive conversation?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#144 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA4oumVW3-aWVp07j_lSQ6qv8sNh6y_ks5r8CRrgaJpZM4NhhFU>
.
|
|
i think i'm fine with the pr, maybe some extensions can be removed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.