Skip to content

Commit

Permalink
Clean up tasks API in vscode.d.ts
Browse files Browse the repository at this point in the history
Part of #124362
  • Loading branch information
alexr00 committed Nov 10, 2021
1 parent cc98e60 commit 042a6e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/vs/vscode.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6577,7 +6577,7 @@ declare module 'vscode' {
* Whether the task that is part of this group is the default for the group.
* This property cannot be set through API, and is controlled by a user's task configurations.
*/
readonly isDefault?: boolean;
readonly isDefault: boolean | undefined;

/**
* The ID of the task group. Is one of TaskGroup.Clean.id, TaskGroup.Build.id, TaskGroup.Rebuild.id, or TaskGroup.Test.id.
Expand Down Expand Up @@ -6913,7 +6913,7 @@ declare module 'vscode' {
/**
* The task's scope.
*/
readonly scope?: TaskScope.Global | TaskScope.Workspace | WorkspaceFolder;
readonly scope: TaskScope.Global | TaskScope.Workspace | WorkspaceFolder | undefined;

/**
* The task's name
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/api/common/extHostTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1776,7 +1776,7 @@ export enum TaskPanelKind {
@es5ClassCompat
export class TaskGroup implements vscode.TaskGroup {

isDefault?: boolean;
isDefault: boolean | undefined;
private _id: string;

public static Clean: TaskGroup = new TaskGroup('clean', 'Clean');
Expand Down

0 comments on commit 042a6e3

Please sign in to comment.