Skip to content

Commit

Permalink
Extract duplicated type
Browse files Browse the repository at this point in the history
  • Loading branch information
mjbvz committed Nov 10, 2021
1 parent 0fed1d8 commit 333ba03
Showing 1 changed file with 15 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,19 @@ export interface INotebookDelegateForWebview {
triggerScroll(event: IMouseWheelEvent): void;
}

interface BacklayerWebviewOptions {
readonly outputNodePadding: number;
readonly outputNodeLeftPadding: number;
readonly previewNodePadding: number;
readonly markdownLeftMargin: number;
readonly leftMargin: number;
readonly rightMargin: number;
readonly runGutter: number;
readonly dragAndDropEnabled: boolean;
readonly fontSize: number;
readonly markupFontSize: number;
}

export class BackLayerWebView<T extends ICommonCellInfo> extends Disposable {
element: HTMLElement;
webview: IWebviewElement | undefined = undefined;
Expand All @@ -110,18 +123,7 @@ export class BackLayerWebView<T extends ICommonCellInfo> extends Disposable {
public readonly notebookEditor: INotebookDelegateForWebview,
public readonly id: string,
public readonly documentUri: URI,
private options: {
outputNodePadding: number,
outputNodeLeftPadding: number,
previewNodePadding: number,
markdownLeftMargin: number,
leftMargin: number,
rightMargin: number,
runGutter: number,
dragAndDropEnabled: boolean,
fontSize: number
markupFontSize: number
},
private options: BacklayerWebviewOptions,
private readonly rendererMessaging: IScopedRendererMessaging | undefined,
@IWebviewService readonly webviewService: IWebviewService,
@IOpenerService readonly openerService: IOpenerService,
Expand Down Expand Up @@ -178,18 +180,7 @@ export class BackLayerWebView<T extends ICommonCellInfo> extends Disposable {
}));
}

updateOptions(options: {
outputNodePadding: number,
outputNodeLeftPadding: number,
previewNodePadding: number,
markdownLeftMargin: number,
leftMargin: number,
rightMargin: number,
runGutter: number,
dragAndDropEnabled: boolean,
fontSize: number
markupFontSize: number
}) {
updateOptions(options: BacklayerWebviewOptions) {
this.options = options;
this._updateStyles();
this._updateOptions();
Expand Down

0 comments on commit 333ba03

Please sign in to comment.