feat: Support more dotenv options #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options
Path
Default: .env
You can specify a custom path if your file containing environment
variables is named or located differently.
require('dotenv').config({path: '/custom/path/to/your/env/vars'})
Encoding
Default: utf8
You may specify the encoding of your file containing environment
variables using this option.
require('dotenv').config({encoding: 'base64'})
benoror
requested changes
Mar 20, 2017
There was a problem hiding this comment.
Hi @zhongzhi107 thanks for your contrib, and sorry for the late response. I proposed some simple changes, other than that LGTM :)
lib/exec.js
Outdated
| if (key in program) { | ||
| dotenvConfig[key] = program[key]; | ||
| } | ||
| }); |
There was a problem hiding this comment.
can you simplify this by using object-assign (as we're already using it here) 😄
Something like:
var dotenvConfig = objectAssign({ silent: true }, program);Or more specific:
var dotenvConfig = objectAssign({ silent: true }, {
encoding: program.encoding,
path: program.path
});Thoughts?
There was a problem hiding this comment.
Good idea!
I'll do it right away.
README.md
Outdated
|
|
||
| ``` | ||
| bnr watch-client -s | ||
| ``` | ||
|
|
||
| And you can use `-p` or verbose `--path` specify a custom path of dotenv file |
There was a problem hiding this comment.
And you can use -p or verbose --path to specify a custom path of dotenv file
README.md
Outdated
| bnr start-dev --path=/custom/path/to/your/env/vars | ||
| ``` | ||
|
|
||
| Also use `-e` or verbose `--encoding` specify the encoding of dotenv file |
There was a problem hiding this comment.
Also use -e or verbose --encoding to specify the encoding of dotenv file
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, I want to control dotenv more precisely, so I added some options to dotenv. Options are as follows:
Options
Path
Default: .env
You can specify a custom path if your file containing environment
variables is named or located differently.
better-npm-run your-task --path=/custom/path/to/your/env/varsor use short name
better-npm-run your-task -p /custom/path/to/your/env/varsEncoding
Default: utf8
You may specify the encoding of your file containing environment
variables using this option.
better-npm-run your-task -e base64