Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Console Error when data are zeros #33

Closed
Gondorff opened this issue Jan 21, 2014 · 2 comments · Fixed by #36
Closed

JS Console Error when data are zeros #33

Gondorff opened this issue Jan 21, 2014 · 2 comments · Fixed by #36

Comments

@Gondorff
Copy link

Given all zero data, e.g. <span class="bar">0,0,0,0,0</span>, the browser has an error in the JS Console:

Error: Invalid value for attribute y="NaN" jquery.peity.js:12

And the bar chart base-line will show at the top of the span rather than the bottom.
@benpickles
Copy link
Owner

Thanks for reporting, the fix has been released in version 2.0.1.

@Gondorff
Copy link
Author

Thanks for the quick update! Looks good now.

benpickles added a commit that referenced this issue Mar 25, 2014
@benpickles
Fixes #33 without causing #34.
78f88fc
@benpickles benpickles mentioned this issue Mar 25, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix all-zero bar chart properly benpickles/peity
2 participants
@benpickles @Gondorff