Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force option #20

Closed
wants to merge 1 commit into from
Closed

Conversation

tobiaskohlbau
Copy link

@tobiaskohlbau tobiaskohlbau commented Mar 13, 2019

Hi thanks for your project, very useful tool ✌

I've got the issue that when using the new go version in conjunction with force closing the application the socket is left behind. (I have a shortcut to the executable within my taskbar and close the program quit often without issuing ctrl+c in the opened command prompt)

This PR adds an option --force which in case of an AddressAlreadyInUse error tries to unlink the specified socket path. Maybe you consider this option as a viable addition to your project.

@lars18th
Copy link

lars18th commented May 8, 2019

Hi,

Is this project stalled?

@benpye
Copy link
Owner

benpye commented May 8, 2019

Hey, sorry I still use this often.

@tobiaskohlbau if you can split the force option from the other commits I'll try and get this in.

@lars18th
Copy link

lars18th commented May 8, 2019

Hey, sorry I still use this often.

Me too! It's the only solution to use PuTTY Pageant with the Windows 10 native SSH client.

@tobiaskohlbau if you can split the force option from the other commits I'll try and get this in.

I hope this PR will be merged then.

Adds option --force to enable the option
to reuse a socket by running a unlink
in case of an AddressAlreadyInUse error.

Signed-off-by: Tobias Kohlbau <tobias@kohlbau.de>
@tobiaskohlbau
Copy link
Author

Sorry for the delay, I missed the comments.

@benpye of course not every commit should be part of this PR I forgot that I didn't created a specific branch for this feature and kept working on it. I've cleaned everything up and the PR should be clean by now. Let me know if there are some suggestions or changes you would like to have before merging this.

@benpye benpye closed this May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants