Merge pull request JuliaAI#131 from barucden/master

Allow fitting using AbstractMatrix instead of Matrix
bensadeghi · Aug 6, 2020 · 51461fd · 51461fd
2 parents 6db23fc + 6baf10b
commit 51461fd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/classification/tree.jl b/src/classification/tree.jl
@@ -257,7 +257,7 @@ module treeclassifier
     end
 
     function _fit(
-            X                     :: Matrix{S},
+            X                     :: AbstractMatrix{S},
             Y                     :: AbstractVector{Int},
             W                     :: AbstractVector{U},
             loss                  :: Function,
@@ -304,7 +304,7 @@ module treeclassifier
     end
 
     function fit(;
-            X                     :: Matrix{S},
+            X                     :: AbstractMatrix{S},
             Y                     :: AbstractVector{T},
             W                     :: Union{Nothing, AbstractVector{U}},
             loss=util.entropy     :: Function,

diff --git a/src/regression/tree.jl b/src/regression/tree.jl
@@ -260,7 +260,7 @@ module treeregressor
     end
 
     function _fit(
-            X                     :: Matrix{S},
+            X                     :: AbstractMatrix{S},
             Y                     :: AbstractVector{Float64},
             W                     :: AbstractVector{U},
             max_features          :: Int,
@@ -303,7 +303,7 @@ module treeregressor
     end
 
     function fit(;
-            X                     :: Matrix{S},
+            X                     :: AbstractMatrix{S},
             Y                     :: AbstractVector{Float64},
             W                     :: Union{Nothing, AbstractVector{U}},
             max_features          :: Int,