Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homebrew package #54

Closed
ghost opened this issue Nov 2, 2023 · 15 comments
Closed

Add homebrew package #54

ghost opened this issue Nov 2, 2023 · 15 comments

Comments

@ghost
Copy link

ghost commented Nov 2, 2023

It would be lovely to have a homebrew-core package to just run: brew install tailspin.

Alternatively a tailpsin tap would be a nice solution, then a bensadeh/homebrew-tap repo is needed and to install would need:

brew tap bensadeh/tap
brew install tailspin
@LaurentFough
Copy link
Contributor

LaurentFough commented Nov 2, 2023

I've created a Homebrew package formula... tested & installed.
Will submit a PR.

Small issue:

  • there's already a Formula named spin, which installs a spin binary.
  • this can be handled with Homebrew's conflicts_with functionality, to prevent the install if the spin package is already installed.
    • may need to looking into linking tailpin spin to tailspin as a cleaner install.
    • ^^ depends on how @bensadeh feels about this.

—-
Will also tweak formula for increased Homebrew compliance.

@bensadeh
Copy link
Owner

bensadeh commented Nov 2, 2023

Thank you so much, @LaurentFough ! Can't believe how fast that was 🙏 .

It would be great if the package name could be tailspin and the binary name be spin. Is that possible?

@LaurentFough
Copy link
Contributor

LaurentFough commented Nov 2, 2023

Update: temp Formula here: github.com/LaurentFough/ tailspin.rb

Download & Review (of course), then Install with:

$ brew install --formula <path_to>/tailspin.rb

@LaurentFough
Copy link
Contributor

Thank you so much, @LaurentFough ! Can't believe how fast that was 🙏 .

It would be great if the package name could be tailspin and the binary name be spin. Is that possible?

Thanks @bensadeh
Ok - package is already named: tailspin.
See my previous comment about the conflicting spin package.
—-
Would be cleaner for you to rename upstream as tailspin; rather than installing as spin and renaming...

@bensadeh
Copy link
Owner

bensadeh commented Nov 2, 2023

I prefer spin as the binary name. Besides, tailspin is already a sort of builtin binary on macOS.

@LaurentFough
Copy link
Contributor

I prefer spin as the binary name. Besides, tailspin is already a sort of builtin binary on macOS.

ok, then as is... the current formula will install and work as expected, and will warn/notify the user if they already have the other spin installed.

@bensadeh
Copy link
Owner

bensadeh commented Nov 2, 2023

Thanks again @LaurentFough , really appreciate how quickly you managed to put this together 🙏

@LaurentFough
Copy link
Contributor

Thanks again @LaurentFough , really appreciate how quickly you managed to put this together 🙏

I wanted to test on macOS, so no worries & You're welcome.

@LaurentFough
Copy link
Contributor

  • Added Homebrew/tap installation instructions as well.

@bensadeh
Copy link
Owner

bensadeh commented Nov 3, 2023

Thank you again @LaurentFough . Merged in #56 .

@ghost
Copy link
Author

ghost commented Nov 3, 2023

Honestly, I don't think this how homebrews tap system is meant to work. My suggestions were completely ignored. Also is there any automation for a version bump/update?

@bensadeh
Copy link
Owner

bensadeh commented Nov 3, 2023

A PR to add tailspin as formula to core has been merged. I haven't had a chance to test it, but in time the tap will be replaced with the core formula.

@ghost
Copy link
Author

ghost commented Nov 3, 2023

Oh neat!

brew uninstall tailspin
brew untap bensadeh/tailspin
brew update
brew install tailspin

works!

@bensadeh
Copy link
Owner

bensadeh commented Nov 3, 2023

Great, I will update the readme with the changes. Thanks for helping with the tap in the meantime @LaurentFough . Sorry your tap couldn't be used more, but it is easier for me to let the formula from core be maintained and updated there.

@LaurentFough
Copy link
Contributor

Honestly, I don't think this how homebrews tap system is meant to work. My suggestions were completely ignored. Also is there any automation for a version bump/update?

@qa-alexander-eimer That actually is how taps are supposed to work.
For 3rd-Party taps, anyway - the only missing ingredient was the provision of a homebrew-tailspin repo.
Everything else was compliant with Homebrew recommendations.

@bensadeh No worries; I prefer the submission to Homebrew-core as well.

If you're going to create an automation for release updates, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants