Fix #88 Breaks with mini-css-extract-plugin@1.3.0 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensampaio
force-pushed
the
fix/css-module-buffer-issue
branch
from
e0be140
to
e22c043
Compare
mihkeleidast
reviewed
Nov 9, 2020
lib/SvgStorePlugin.js
Outdated
| case 'CssModule': { | ||
| const content = sprite.replacePathsWithInterpolatedPaths(module.content.toString()); | ||
|
|
||
| if (Buffer.isBuffer(module.content)) { |
There was a problem hiding this comment.
Shouldn't there be an else if (typeof module.content === 'string') here? I'm guessing the update would break those using an older version of mini-css-extract-plugin? I don't use this SVG path in CSS myself but just noticed it...
There was a problem hiding this comment.
You are right, thanks for checking! That was my intention and then I ended up doing it wrong 😅
Should be fixed now.
There was a problem hiding this comment.
I released it as 7.1.0-beta.2. Can you let me know if this still works for you just as a sanity check?
There was a problem hiding this comment.
Looks like it works in my repro repository.
There was a problem hiding this comment.
Thanks! I'll merge it and release it as 7.1.0 then :)
* Convert the `CssModule` content to string in order to be able to replace the Sprite URL. * Convert the `CssModule` content back to `Buffer` if it was a buffer before so that the plugin remains compatible with older versions of `CssModule`. * Change from `[hash]` to `[contenthash]` since this is now the recommended way of generating hashes and because this should also result in less filename changes. * Update the `react` example installation so that it uses hashes in order to no longer cache assets.
* Convert the `CssModule` content back to the original format so that the plugin remains compatible all versions of `CssModule`.
bensampaio
force-pushed
the
fix/css-module-buffer-issue
branch
from
b2b4a3e
to
6d9e14a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CssModulecontent to string in order to be able to replace the Sprite URL.CssModulecontent back toBufferif it was a buffer before so that the plugin remains compatible with older versions ofCssModule.[hash]to[contenthash]since this is now the recommended way of generating hashes and because this should also result in less filename changes.reactexample installation so that it uses hashes in order to no longer cache assets.