Fix for use isinstance({}, dict) #12

dongweiming · 2014-08-01T02:56:42Z

I use flask-mako. But there was a problem, Below is my code:

app.py

from flask import Flask
from flask.ext.mako import MakoTemplates, render_template
from plim import preprocessor

app = Flask(__name__, template_folder="templates")
app.config['MAKO_TRANSLATE_EXCEPTIONS'] = False
app.config['MAKO_DEFAULT_FILTERS'] = ['decode.utf_8', 'h'] 
#app.config['MAKO_PREPROCESSOR'] = preprocessor

mako = MakoTemplates()
mako.init_app(app)

@app.route('/')
def index():
    s = 'a string'
    return render_template('test_no_plim.html', **locals())

if __name__ == '__main__':
    app.run(debug=True)

test_no_plim.html

<html>
  <body>
    <div>
      % if isinstance(s, dict):
      <a>dict</a>
      % else:
      <p>not dict</p>
    % endif
    </div>
  </body>
</html>

Display the following error when I visit http://127.0.0.1:5000/

TypeError

TypeError: isinstance() arg 2 must be a class, type, or tuple of classes and types

I found the reason is in jinja2 's commit 76c280bf5b2263a435e38e0b3612c23eb633ed79. It add a function that named dict interferes the built-in dict after update context from app.jinja_env.globals

dongweiming · 2014-12-08T00:09:46Z

Why close it?

benselme · 2014-12-08T13:19:42Z

Thanks for submitting it, but not useful enough for enough people. Besides
if we remove dict then why not remove other things as well ? I think we
should leave that as is. You should be able to find a workaround without
modifying flask-mako.

On Sun, Dec 7, 2014 at 7:09 PM, 小明 notifications@github.com wrote:

Why close it?

—
Reply to this email directly or view it on GitHub
#12 (comment).

Fix for use isinstance({}, dict)

91337ba

benselme closed this Dec 7, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for use isinstance({}, dict) #12

Fix for use isinstance({}, dict) #12

dongweiming commented Aug 1, 2014

dongweiming commented Dec 8, 2014

benselme commented Dec 8, 2014

Fix for use isinstance({}, dict) #12

Fix for use isinstance({}, dict) #12

Conversation

dongweiming commented Aug 1, 2014

app.py

test_no_plim.html

dongweiming commented Dec 8, 2014

benselme commented Dec 8, 2014