Skip to content

Commit

Permalink
Fix: Interacting with input field should pause the live poll (#1210)
Browse files Browse the repository at this point in the history
* Fix: Interacting with input field pauses the live poll

* Fix "data-live-poll-region" and remove JS change

---------

Co-authored-by: Ben Sheldon [he/him] <bensheldon@gmail.com>
  • Loading branch information
sparshalc and bensheldon committed Jan 19, 2024
1 parent 6a7332a commit 165c26a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/views/good_job/shared/_filter.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div data-live-poll-region id="filter" class="">
<div id="filter">
<div class="">
<div class="border-bottom mb-3">
<h2 class="pt-3 pb-2"><%= title %></h2>
Expand Down Expand Up @@ -47,7 +47,7 @@
</div>
<% end %>

<ul class="nav nav-tabs my-3">
<ul data-live-poll-region="filter-tabs" class="nav nav-tabs my-3">
<li class="nav-item">
<%= link_to t(".all"), filter.to_params(state: nil), class: "nav-link #{"active" unless params[:state].present?}" %>
</li>
Expand Down

0 comments on commit 165c26a

Please sign in to comment.