Fix latest migration not affecting GoodJob.migrated?

bensheldon · Apr 30, 2024 · 37f2c2e · 37f2c2e
1 parent 2586313
commit 37f2c2e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/...good_job_execution_error_backtrace.rb.erb → ...good_job_execution_error_backtrace.rb.erb b/...good_job_execution_error_backtrace.rb.erb → ...good_job_execution_error_backtrace.rb.erb
diff --git a/lib/good_job.rb b/lib/good_job.rb
@@ -277,8 +277,8 @@ def self.deprecator
   # @return [Boolean]
   def self.migrated?
     # Always update with the most recent migration check
-    GoodJob::Execution.reset_column_information
-    GoodJob::Execution.candidate_lookup_index_migrated?
+    GoodJob::DiscreteExecution.reset_column_information
+    GoodJob::DiscreteExecution.backtrace_migrated?
   end
 
   ActiveSupport.run_load_hooks(:good_job, self)

diff --git a/spec/generators/good_job/update_generator_spec.rb b/spec/generators/good_job/update_generator_spec.rb
@@ -58,6 +58,16 @@
     expect(normalize_schema(only_update_schema)).to eq normalize_schema(install_schema)
   end
 
+  it 'has files with unique number prefixes' do
+    update_path = "lib/generators/good_job/templates/update/migrations"
+    expect(File).to exist(update_path)
+
+    migrations = Dir.glob("#{update_path}/*")
+    prefixes = migrations.map { |path| File.basename(path).split("_", 2).first }
+
+    expect(prefixes.map(&:to_i)).to eq(1.upto(prefixes.size).to_a)
+  end
+
   def normalize_schema(text)
     text.sub(/\.define\(version: ([\d_]*)\)/, '.define(version: SCHEMA_VERSION)')
   end