Fix label modifications on job instance polluting labels on job class (…

…#1355)
bensheldon · May 23, 2024 · 4f2dae4 · 4f2dae4
1 parent db58c20
commit 4f2dae4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/good_job/active_job_extensions/labels.rb b/lib/good_job/active_job_extensions/labels.rb
@@ -8,7 +8,7 @@ module Labels
       module Prepends
         def initialize(*arguments)
           super
-          self.good_job_labels = Array(self.class.good_job_labels)
+          self.good_job_labels = Array(self.class.good_job_labels.dup)
         end
 
         def enqueue(options = {})

diff --git a/spec/lib/good_job/active_job_extensions/labels_spec.rb b/spec/lib/good_job/active_job_extensions/labels_spec.rb
@@ -53,6 +53,18 @@ def perform
     expect(active_job.good_job_labels).to eq []
   end
 
+  it 'the instance value does not modify the class label value' do
+    TestJob.good_job_labels = ["buffalo"]
+    TestJob.before_enqueue { |job| job.good_job_labels << "gopher" }
+
+    job = TestJob.perform_later
+    expect(job.good_job_labels).to eq %w[buffalo gopher]
+    expect(TestJob.good_job_labels).to eq ["buffalo"]
+
+    job = TestJob.perform_later
+    expect(job.good_job_labels).to eq %w[buffalo gopher]
+  end
+
   it 'is unique' do
     TestJob.good_job_labels = %w[buffalo gopher gopher]
     TestJob.perform_later