Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 deprecations are still present #1399

Closed
Earlopain opened this issue Jul 8, 2024 · 2 comments · Fixed by #1406
Closed

v3 deprecations are still present #1399

Earlopain opened this issue Jul 8, 2024 · 2 comments · Fixed by #1406

Comments

@Earlopain
Copy link
Collaborator

specifically for cleanup_interval_jobs and cleanup_interval_seconds. I guess I also expected smaller_number_is_higher_priority to disappear but that doesn't deprecate anymore so I guess its fine.
@bensheldon
Copy link
Owner

🤦 I got so caught up in moving the Job files around I missed this. Thank you for the help 🙇

I'm going to get a release cut right now for #1402, because that seems most operationally impactful, then I can clean up those others.

@Earlopain
Copy link
Collaborator Author

That sounds good, thank you. I agree these are not as important since there is no behaviour change between v3 and v4

@bensheldon bensheldon mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
2 participants
@bensheldon @Earlopain