Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for rails g good_job:install #57

Closed
bensheldon opened this issue Jul 24, 2020 · 0 comments · Fixed by #94
Closed

Add test for rails g good_job:install #57

bensheldon opened this issue Jul 24, 2020 · 0 comments · Fixed by #94
Projects
Backlog

Comments

@bensheldon
Copy link
Owner

There should be a test that the generator, at the very least, does not blow up when being run.

Deferred because it potentially involves filesystem changes.

  • Validating the stdout output of bin/rails g good_job:install --pretend --force looks like the right shape would be good enough.
  • Otherwise, would need to potentially overwrite the existing migration file in spec/dummy and then restore it for a deeper inspection of the generated files.

Follow-up to #56
@bensheldon bensheldon added this to Inbox in Backlog Jul 24, 2020
@thedanbob thedanbob mentioned this issue Jul 24, 2020
Merged
@arku arku mentioned this issue Aug 25, 2020
Merged
Backlog automation moved this from Inbox to Done Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for rails g good_job:install arku/good_job
1 participant
@bensheldon