Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for rails g good_job:install #94

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

arku
Copy link
Contributor

@arku arku commented Aug 25, 2020

Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. I really appreciate this work 🎉

My comments are primarily around naming. This is hard 😄

spec/support/good_job_test_helper.rb Outdated Show resolved Hide resolved
spec/support/good_job_test_helper.rb Outdated Show resolved Hide resolved
spec/lib/generators/good_job/install_generator_spec.rb Outdated Show resolved Hide resolved
@arku arku force-pushed the test/install-generator branch 2 times, most recently from 1f03b50 to bc9eaae Compare August 25, 2020 03:55
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more thoughts about organizing the ExampleAppHelper file and making it ✨

spec/support/example_app_helper.rb Show resolved Hide resolved
spec/support/example_app_helper.rb Outdated Show resolved Hide resolved
spec/support/example_app_helper.rb Show resolved Hide resolved
spec/lib/generators/good_job/install_generator_spec.rb Outdated Show resolved Hide resolved
@arku arku force-pushed the test/install-generator branch 2 times, most recently from a1cf2c3 to ddf6585 Compare August 25, 2020 04:52
@arku arku requested a review from bensheldon August 25, 2020 04:52
@arku arku force-pushed the test/install-generator branch 2 times, most recently from 6be597d to 61ae356 Compare August 26, 2020 03:08
@bensheldon bensheldon merged commit 1ae410c into bensheldon:main Aug 26, 2020
@arku arku deleted the test/install-generator branch August 26, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for rails g good_job:install
2 participants