Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-dropdown): use dropdown-end on locales dropdown #1296

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

WailanTirajoh
Copy link
Contributor

@WailanTirajoh WailanTirajoh commented Mar 23, 2024

Description:

Add class dropdown-menu-end to fix overflow on header locales dropdown open state

Before:

image

After:

image

Other options:

  • Set min width to auto based on child element, it would look like this:

image

@bensheldon bensheldon added the bug Something isn't working label Mar 24, 2024
@bensheldon
Copy link
Owner

@WailanTirajoh thank you! This looks great. How are you able to apply the min-width? It didn't seem to have an effect when I tried it.

@WailanTirajoh
Copy link
Contributor Author

Cool! updated to use min width instead. Bootstrap has min-width: 10rem set to dropdown menu by default, so we need to create custom class min-w-auto to set it auto since bs has no min with auto class (1 level with dropdown-menu class).

@bensheldon bensheldon merged commit 17f33fb into bensheldon:main Mar 24, 2024
20 checks passed
bensheldon added a commit that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants