-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GoodJob::DiscreteExecution#duration column #1374
Conversation
No, The way I've described it in my draft v4 upgrade guide is:
So if we want to calculate across every execution of a job, we want to use DiscreteExecutions. |
@bensheldon okay perfect! |
Well PR should be ready then, and I'll make adjustments to @arnaudlevy's PR about the Performance tab |
Thank you! This is great! I spoke with some Rails/Postgres experts and they recommended using a Postgres |
@bensheldon Will do! Just checked, interval type is compatible with Rails starting from 6.1.0, but as GJ v4 will be Rails 6.1+, shouldn't be an issue! |
@bensheldon Tell me if it's good for you! |
For future reference, this was a nice description of difference between latency and duration: HangfireIO/Hangfire#95 (comment) |
Added a
duration
attribute toGoodJob::DiscreteExecution
, containing the monotonic execution time.The
runtime_latency
method now uses this attribute if migrated correctly.Should I also add this attribute toGoodJob::Execution
and set it when we set thefinished_at
attribute? Because in #1362, I think we should work withGoodJob::Execution
and notGoodJob::DiscreteExecution
. What do you think @bensheldon?