Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Sorbet linting; greatly improve YARD docs #235

Closed
wants to merge 4 commits into from
Closed

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Apr 14, 2021

  • Using sord gem for generating RBI file from documentation
  • Not yet packaging a good_job.rbi file

@bensheldon
Copy link
Owner Author

This PR is blocked by dynamically assigning a class parent:

class Job < Object.const_get(GoodJob.active_record_parent_class)

I posted a question on StackOverflow following Sorbet's support instructions: https://stackoverflow.com/questions/67182040/how-to-hint-sorbet-with-const-get-and-dynamic-parent-class

@bensheldon bensheldon closed this Apr 26, 2021
Backlog automation moved this from In progress to Done Apr 26, 2021
@bensheldon bensheldon reopened this Apr 26, 2021
Backlog automation moved this from Done to In progress Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant