Run Scheduler#warm_cache operation in threadpool executor #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
warm_cache_on_thread
branch
2 times, most recently
from
d4845fb
to
77cf86f
Compare
bensheldon
force-pushed
the
warm_cache_on_thread
branch
2 times, most recently
from
de8c892
to
91d3240
Compare
Reduces the number of created database connections by not creating a connection on the main thread.
bensheldon
force-pushed
the
warm_cache_on_thread
branch
from
91d3240
to
bc12247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of created database connections by not creating a connection on the main thread.
First observed in #236 (comment)
Also fixes a deadlock observed in #236 (comment). Reasoning here: