Updated the code to work on newer versions of python (3.5+) fixes #1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
print is now required to be used as print('test')
and ConfigParser was changed to configparser
fixed some spacing/tab issues
and decleared bytes with b to avoid join problems (join expects string unless there is b before the calling string and should recive all parameters as bytes)
|
Thanks! Seems I missed the notification of the original issue being raised. Based on quick test seems to work OK for me, so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes i made:
print is now required to be used as print('test') insted of print 'test'
and ConfigParser was changed to configparser
fixed some spacing/tab issues
and decleared bytes with b to avoid join problems (join expects string unless there is b before the calling string and should recive all parameters as bytes)
i tested those changes with python 3.5.2 (last updated Jun 25, 2016. )