Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement testing for all operating systems as GitHub Actions #304

Merged
merged 9 commits into from
Sep 6, 2020

Conversation

sahansk2
Copy link
Contributor

@sahansk2 sahansk2 commented Aug 25, 2020

Fixes #297 , replaces #298 , commits taken from #301

@sahansk2
Copy link
Contributor Author

@sahansk2 Can you update this so that flake8 only runs once? For now, it's fine that the windows test uses bash, but we should fix that at some point (can you add an issue?). Also can you put all of the testing commits on another branch? I'd like to merge into master with that first, then get to reviewing this PR. Once we merge that branch into master, then it will be appropriate to merge master into this branch and do a review

If we want to run flake8 only once, it's probably best that a separate workflow is created for that.

@sahansk2
Copy link
Contributor Author

sahansk2 commented Sep 3, 2020

@benthayer This is ready for review.

@benthayer
Copy link
Owner

@sahansk2 It looks like there's something weird going on with Windows testing. Can you take a look? It's getting a OSError('[WinError 6] The handle is invalid'), but I'm not sure what that means. Git can be accessed from the (bash) command line, as seen by the new test I added, so there must be something else going on

@sahansk2
Copy link
Contributor Author

sahansk2 commented Sep 6, 2020

GitPython released 3.1.8 on September 3rd, which apparently broke Windows compatibility.

By the way: it might be better to lock GitPython at 3.1.7 for reasons other than compatibility, for a while at least.

@benthayer
Copy link
Owner

benthayer commented Sep 6, 2020 via email

@sahansk2
Copy link
Contributor Author

sahansk2 commented Sep 6, 2020

Yep, it's been locked in. @benthayer

@benthayer benthayer merged commit 3a51ab8 into benthayer:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up workflow to run Git Gud tests in a Windows environment
2 participants