-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement testing for all operating systems as GitHub Actions #304
Conversation
If we want to run flake8 only once, it's probably best that a separate workflow is created for that. |
@benthayer This is ready for review. |
2328958
to
7336f0a
Compare
@sahansk2 It looks like there's something weird going on with Windows testing. Can you take a look? It's getting a |
7336f0a
to
35b7f54
Compare
a4e66be
to
223f8b5
Compare
GitPython released 3.1.8 on September 3rd, which apparently broke Windows compatibility. By the way: it might be better to lock GitPython at 3.1.7 for reasons other than compatibility, for a while at least. |
Interesting, go ahead and lock it in. We can deal with the upgrade later
…On Sun, Sep 6, 2020, 3:11 PM Sahan Kumarasinghe ***@***.***> wrote:
GitPython released 3.1.8 <https://pypi.org/project/GitPython/#history> on
September 3rd, which apparently broke Windows compatibility.
By the way: it might be better to lock GitPython at 3.1.7 for reasons
other than compatibility, for a while at least.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#304 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABORCY753HXR64Y7WXZI2HLSEPUGTANCNFSM4QKCQVIQ>
.
|
Yep, it's been locked in. @benthayer |
Fixes #297 , replaces #298 , commits taken from #301