-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix benthos.yaml config logic bug #29
Conversation
…needed, because some configuration can only be written in this file, please leave this file controlled by user itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not a maintainer.
Hello, |
# Conflicts: # templates/configmap.yaml
Hello In stream mode, benthos.yaml still always be like this: http:
enabled: true
address: 0.0.0.0:4195
root_path: /benthos
debug_endpoints: false But it should be like this, because http:
enabled: true
address: 0.0.0.0:4195
root_path: /benthos
debug_endpoints: false
metircs:
mapping: |
meta = deleted()
prometheus:
push_url: "prometheus-pushgateway.monitoring:9091"
push_job_name: benthos_push
push_interval: 5s
add_process_metrics: true
add_go_metrics: true
logger:
level: all
format: json
add_timestamp: true |
Thanks for the update - this makes sense and I don't remember if I considered the global configs in streams mode, sorry about that. I would like to retain the config block at the end to inform a user that benthos is running essentially config-less. Let me take a crack at a happy middle ground and propose it here. |
bump |
Closing as completed. See #44 (comment) for more details. |
no matter benthos run on streams mode or not, benthos.yaml is always needed, because some configuration can only be written in this file, please leave this file controlled by user itself