fix benthos.yaml config logic bug

[sytgj7896321]

no matter benthos run on streams mode or not, benthos.yaml is always needed, because some configuration can only be written in this file, please leave this file controlled by user itself

[wrdls]

LGTM, but I'm not a maintainer.

[difabion]

Hello,
Please check the env support implemented in 0.7.0 and see if that suits your needs. There is definitely a bug in the config logic; having streams set to false shouldn't be disabling the rest of the block. Let me mess with it this week and get it fixed, bear with me!

[sytgj7896321]

Hello
Now we have env support in version 0.7.2, but config logic bug still not fixed.

In stream mode, benthos.yaml still always be like this:

http:
  enabled: true
  address: 0.0.0.0:4195
  root_path: /benthos
  debug_endpoints: false

But it should be like this, because metrics, logger and some other fields must be in benthos.yaml:

http:
  enabled: true
  address: 0.0.0.0:4195
  root_path: /benthos
  debug_endpoints: false
metircs:
  mapping: |
    meta = deleted()
  prometheus:
    push_url: "prometheus-pushgateway.monitoring:9091"
    push_job_name: benthos_push
    push_interval: 5s
    add_process_metrics: true
    add_go_metrics: true
logger:
  level: all
  format: json
  add_timestamp: true

@difabion

[difabion]

Thanks for the update - this makes sense and I don't remember if I considered the global configs in streams mode, sorry about that. I would like to retain the config block at the end to inform a user that benthos is running essentially config-less. Let me take a crack at a happy middle ground and propose it here.

[maxsargentdev]

bump

[charlie-haley]

Closing as completed. See #44 (comment) for more details.