Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nats-io import path #275

Merged
merged 2 commits into from Sep 11, 2019
Merged

Fix nats-io import path #275

merged 2 commits into from Sep 11, 2019

Conversation

asiragusa
Copy link
Contributor

Hi @Jeffail,

Recently nats changed their repositories to https://github.com/nats-io/nats.go and https://github.com/nats-io/stan.go and this breaks go mod. I updated the dependencies, but still can't run go mod tidy because of nats-io/stan.go#280

@asiragusa
Copy link
Contributor Author

Ok also tests are failing, we must wait for nats-io/stan.go#280

@asiragusa
Copy link
Contributor Author

@Jeffail it works now, we might still track the original issue to fix the indirect dependency

@Jeffail Jeffail merged commit 2cdd483 into benthosdev:master Sep 11, 2019
@Jeffail
Copy link
Member

Jeffail commented Sep 11, 2019

Cool, thanks @asiragusa!

@asiragusa asiragusa deleted the fix-nats branch September 12, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants