Skip to content

Commit

Permalink
fix(build): make sure to parse pip_args in correct order (#4722)
Browse files Browse the repository at this point in the history
fix(build): make sure to pass pip_args before -r

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
  • Loading branch information
aarnphm committed May 10, 2024
1 parent 6e9b64d commit 9221551
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/bentoml/_internal/bento/install.sh.j2
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ BENTOML_VERSION=${BENTOML_VERSION:-<< bentoml_version >>}
pushd "$BASEDIR" &>/dev/null
if [ -f "$REQUIREMENTS_LOCK" ]; then
echo "Installing pip packages from 'requirements.lock.txt'.."
pip3 install -r "$REQUIREMENTS_LOCK" "${PIP_ARGS[@]}"
pip3 install "${PIP_ARGS[@]}" -r "$REQUIREMENTS_LOCK"
else
if [ -f "$REQUIREMENTS_TXT" ]; then
echo "Installing pip packages from 'requirements.txt'.."
pip3 install -r "$REQUIREMENTS_TXT" "${PIP_ARGS[@]}"
pip3 install "${PIP_ARGS[@]}" -r "$REQUIREMENTS_TXT"
fi
fi
popd &>/dev/null
Expand All @@ -33,7 +33,7 @@ wheels=($WHEELS_DIR/*.whl)
{% raw %}
if [ ${#wheels[@]} -gt 0 ]; then
echo "Installing wheels packaged in Bento.."
pip3 install "${wheels[@]}" "${PIP_ARGS[@]}"
pip3 install "${PIP_ARGS[@]}" "${wheels[@]}"
fi
{% endraw %}
Expand Down

0 comments on commit 9221551

Please sign in to comment.