Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python packaged model implicitly requires bentoml package #395

Closed
kevin-hanselman opened this issue Nov 25, 2019 · 3 comments
Closed

Python packaged model implicitly requires bentoml package #395

kevin-hanselman opened this issue Nov 25, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kevin-hanselman
Copy link
Contributor

kevin-hanselman commented Nov 25, 2019

Describe the bug

A Python package built by BentoML requires the bentoml Python package implicitly.

To Reproduce

$ pip install my_packaged_model

Then:

>>> import my_packaged_model
ModuleNotFoundError: No module named 'bentoml'

Not only do I need to install BentoML, I need to install the precise version used to create the Python package, else the package fails to import because of apparent BentoML API changes.

Expected behavior

import my_packaged_model should Just Work.

Environment:

  • OS: Arch Linux
  • Python Version: Both Python 3.8.0 (Arch Linux) and Docker image python:3.7
  • BentoML Version: Both 0.4.9 and 0.5.0
@kevin-hanselman kevin-hanselman added the bug Something isn't working label Nov 25, 2019
@parano parano self-assigned this Nov 25, 2019
@parano
Copy link
Member

parano commented Nov 25, 2019

@Kevlar1818 Thanks for reporting this issue! The BentoML package should indeed be added to the install_requires list with fixed version, will follow up with a PR soon.

@parano
Copy link
Member

parano commented Nov 25, 2019

The fix has just been merged to master #396 @kevlar1818 thanks again for reporting the issue.

We will do some more testing before making a release, in the meanwhile, feel free to try it out by installing BentoML from master branch: pip install git+https://github.com/bentoml/BentoML.git

@parano
Copy link
Member

parano commented Nov 26, 2019

Release 0.5.2 is out now including the fix. It should be able to use saved BentoService bundle as PyPI package with all the pip dependencies specified with the setup.py file.

Closing this issue now, feel free to reopen if you are still seeing this/related issues with it.

@parano parano closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants