Refactor Adapters #1056
Merged
Refactor Adapters #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## refactor-adapters #1056 +/- ##
======================================================
- Coverage 63.39% 34.07% -29.33%
======================================================
Files 124 128 +4
Lines 8259 7895 -364
======================================================
- Hits 5236 2690 -2546
- Misses 3023 5205 +2182
Continue to review full report at Codecov.
|
bojiang
force-pushed
the
input-adapters-2
branch
from
c921985
to
b9fa86a
Compare
Closed
18 tasks
parano
reviewed
Sep 4, 2020
bentoml/_version.py
Outdated
| pieces["long"] = full_out | ||
| pieces["short"] = full_out[:7] # maybe improved later | ||
| pieces["error"] = None | ||
| pieces = {"long": full_out, "short": full_out[:7], "error": None} |
There was a problem hiding this comment.
what's the reason for this change? this is actually not our code, it is from the versioneer project
parano
reviewed
Sep 4, 2020
bentoml/adapters/default_output.py
Outdated
| return detect_suitable_adapter(result[s]) | ||
| if isinstance(result, (list, tuple)): | ||
| return detect_suitable_adapter(result[0]) | ||
| # if isinstance(result, (list, tuple)): |
parano
reviewed
Sep 5, 2020
bentoml/adapters/dataframe_input.py
Outdated
| "Missing required dependency 'pandas' for DataframeInput, install " | ||
| "with `pip install pandas`" | ||
| ) | ||
| if typ != "frame": |
There was a problem hiding this comment.
Any reason not to just remove the typ parameter?
bentoml/service.py
Outdated
| """ | ||
|
|
||
| def decorator(func): | ||
| _api_name = func.__name__ if api_name is None else api_name | ||
| validate_inference_api_name(_api_name) | ||
|
|
||
| if input is None: | ||
| # support bentoml<=0.7 | ||
| # Support passing the desired adapter without instantiation |
There was a problem hiding this comment.
nit: "Raise error when input adapter class passed without instantiation"
parano
reviewed
Sep 5, 2020
bentoml/service.py
Outdated
|
|
||
| def handle_cli(self, cli_args: Sequence[str]) -> int: | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("--max-batch-size", default=sys.maxsize, type=int) |
There was a problem hiding this comment.
could we set a somewhat practical default value here? e.g. 1000?
bojiang
force-pushed
the
input-adapters-2
branch
from
e8825a1
to
8bf1314
Compare
bojiang
force-pushed
the
refactor-adapters
branch
from
f8e16d7
to
8bf1314
Compare
|
Moved to #1070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Component(s) if applicable
Checklist:
./dev/format.shand./dev/lint.shscript have passed(instructions).