-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Easy Ec2 deployment #1160
Conversation
Sorry for too many file changes.Seems like black changed lot of quotes. |
Hi @mayurnewase - could you run And could you look into where the conflicts are from? You may need to rebase or merge with the latest master branch. |
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
- Coverage 65.98% 65.50% -0.48%
==========================================
Files 135 141 +6
Lines 8563 9068 +505
==========================================
+ Hits 5650 5940 +290
- Misses 2913 3128 +215
Continue to review full report at Codecov.
|
Hi @mayurnewase - thank you again for this massive contribution! I really appreciate your effort in refactoring the code, improving code quality in related code path, adding end-to-end tests, and writing up documentation. Great work! I've done some more testing on my end and everything looks good, I will mark it as a beta feature in the next release note and ask folks to try it out and give feedback. Merging now! |
* proto deploymentSpce remaining * cli * fixed * complete functional logic * complete functional logic * remaining: add info in deployment spec,and use it to delete,update stacks/buckets * 3 tests failing for aws_lambda deployment and ec2_deployment tests remaining * formatted * Delete deploy.sh * Delete sample_template.yaml * Delete startup.sh * optional params for containerize * existing tests fixed * update,list,get apis complete * quotes fixed * quotes fixwed * fixed quotes * more options for deployment * separate containerize function for cli and fixed quotes * fixed quotes * error handling * initial tests added * lambda tests imports fixed * tests complete * linted * bug fix * tests fixed * formatted * added spinner * linted * logging * lint * Update image_input.py * default options in update * fixed lambda test * print removed * more tests * bug fixes * test fixes * spelling fixes * Remove bucket on delete deployment Show instance details on describe deployment command bug fixes * full endpoints in describe output * end to end tests added * bug fix * static load balancer * load balancer complete * load balancer and end to end tests complete * bug fix * same bucket,pb validate,state from target health * spelling fixed * tests fixed * bug fixed * more spelling fixes * bug fix * deployment doc added * spelling fix * fixed target group without initial instance * cleanups * lint * lint * cleanup * bug fix * doc and lint fix * added ec2 in ignore spelling list * added ec in ignore spelling list * Fixed docs,added inline comments for e2e tests * Lint fix * lint fix * changed capacity to size * Used defined elb name * formatted * tests fixed * size to desired capacity * fix * added script to create iam user for deployments * policy name fixed * added permissions in doc * spellings ignored * permissions added in deployment doc
Description
One click deployment for AWS ec2 with autoscaling group.
Motivation and Context
For easy deployment without load balancing
How Has This Been Tested?
Types of changes
Component(s) if applicable
Checklist:
./dev/format.sh
and./dev/lint.sh
script have passed(instructions).