[DOC] add examples of query with requests for adapters #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
=======================================
Coverage 65.98% 65.98%
=======================================
Files 135 135
Lines 8563 8563
=======================================
Hits 5650 5650
Misses 2913 2913
Continue to review full report at Codecov.
|
parano
reviewed
Oct 22, 2020
|
|
||
| with open("test.jpg", "rb") as f: | ||
| image_bytes = f.read() | ||
| with open("anno.json", "rb") as f: |
There was a problem hiding this comment.
give the user an alternative to use some in-memory data as the JSON annotation data?
e.g.
annotations = { "age": 10, "bar": "foo" }
anno_bytes = json.dumps(annotations).encode()
There was a problem hiding this comment.
That is definitely helpful! I think in many cases the annotation part of the request is created at runtime and not read from file.
parano
reviewed
Oct 22, 2020
| import requests | ||
|
|
||
| with open("test.jpg", "rb") as f: | ||
| image_bytes = f.read() |
There was a problem hiding this comment.
Similarly let's give the user another example to turn a PIL image object into a request?
pncnmnp
pushed a commit
to MLH-Fellowship/BentoML
that referenced
this pull request
Nov 1, 2020
* [DOC] add examples of query with requests for adapters * add query example that post images from PIL Image
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
* [DOC] add examples of query with requests for adapters * add query example that post images from PIL Image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title.
Motivation and Context
#1201
How Has This Been Tested?
Types of changes
Component(s) if applicable
Checklist:
./dev/format.shand./dev/lint.shscript have passed(instructions).