Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import paths to reflect fastai2->fastai rename #1227

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

iancoffey
Copy link
Contributor

Description

Going through the code comments made it pretty confusing since the import paths across projects vary.

This just updates those comments with what works.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1227   +/-   ##
=======================================
  Coverage   65.98%   65.98%           
=======================================
  Files         135      135           
  Lines        8563     8563           
=======================================
  Hits         5650     5650           
  Misses       2913     2913           
Impacted Files Coverage Δ
bentoml/frameworks/fastai.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d64b1...9da130d. Read the comment docs.

@parano
Copy link
Member

parano commented Nov 5, 2020

Thank you for fixing this @iancoffey !

@parano parano merged commit 5edff36 into bentoml:master Nov 5, 2020
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants