Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add integration test for LightGBM #1243

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

telescopic
Copy link
Contributor

Description

This PR adds an integration test for the LightGBM Model artifact code

Motivation and Context

LightGBM artifact code is currently not tested.

This PR solves #1197

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@pep8speaks
Copy link

pep8speaks commented Nov 14, 2020

Hello @telescopic, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2020-11-14 02:59:03 UTC

@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #1243 (fc003bc) into master (2923623) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
+ Coverage   66.03%   66.08%   +0.04%     
==========================================
  Files         135      141       +6     
  Lines        8553     9169     +616     
==========================================
+ Hits         5648     6059     +411     
- Misses       2905     3110     +205     
Impacted Files Coverage Δ
bentoml/yatai/deployment/utils.py 41.66% <0.00%> (-9.19%) ⬇️
bentoml/yatai/deployment/operator.py 65.62% <0.00%> (-6.79%) ⬇️
bentoml/yatai/validator/deployment_pb_validator.py 75.67% <0.00%> (-6.15%) ⬇️
bentoml/yatai/client/bento_repository_api.py 69.01% <0.00%> (-5.99%) ⬇️
bentoml/yatai/client/deployment_api.py 32.20% <0.00%> (-4.12%) ⬇️
bentoml/cli/bento_service.py 67.15% <0.00%> (-2.55%) ⬇️
bentoml/frameworks/onnx.py 81.69% <0.00%> (-2.37%) ⬇️
bentoml/service/__init__.py 87.77% <0.00%> (-2.10%) ⬇️
bentoml/cli/utils.py 65.54% <0.00%> (-0.85%) ⬇️
bentoml/saved_bundle/config.py 88.63% <0.00%> (-0.17%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2923623...fc003bc. Read the comment docs.

@telescopic
Copy link
Contributor Author

@flosincapite , @parano , @yubozhao Please review my pull request!
Thanks in advance! :D

@yubozhao yubozhao merged commit 9ac61a4 into bentoml:master Nov 16, 2020
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* Add LightGBMModelService class

* Add integration test for LightGBM model artifact

* Add .sh file for lightgbm integration test

* Add code to clean up saved bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants