Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test]Add more logging information for ec2 end-to-end test #1270

Merged
merged 9 commits into from
Nov 25, 2020

Conversation

yubozhao
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1270 (5c5fe97) into master (f9ae334) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   66.30%   66.30%   -0.01%     
==========================================
  Files         143      143              
  Lines        9314     9318       +4     
==========================================
+ Hits         6176     6178       +2     
- Misses       3138     3140       +2     
Impacted Files Coverage Δ
bentoml/cli/aws_ec2.py 55.14% <ø> (ø)
bentoml/yatai/deployment/aws_ec2/operator.py 69.19% <ø> (-0.15%) ⬇️
bentoml/yatai/deployment/aws_utils.py 37.00% <42.85%> (-0.90%) ⬇️
bentoml/utils/usage_stats.py 90.78% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ae334...5c5fe97. Read the comment docs.

@yubozhao yubozhao merged commit e297b2d into bentoml:master Nov 25, 2020
uhbuhb pushed a commit to MLH-Fellowship/BentoML that referenced this pull request Feb 17, 2021
…l#1270)

* add additional logs for e2e ec2 test

* add more info for logs

* Update cli_operations.py

* pass namespace for test deployment deletion

* Update aws_ec2.py

* make delete ecr method less brutal
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
…l#1270)

* add additional logs for e2e ec2 test

* add more info for logs

* Update cli_operations.py

* pass namespace for test deployment deletion

* Update aws_ec2.py

* make delete ecr method less brutal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant