Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]add integration test for tf1 #1285

Merged
merged 3 commits into from
Dec 2, 2020
Merged

[CI]add integration test for tf1 #1285

merged 3 commits into from
Dec 2, 2020

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Dec 1, 2020

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1285 (4bb411e) into master (df11494) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   66.25%   66.24%   -0.02%     
==========================================
  Files         144      144              
  Lines        9321     9321              
==========================================
- Hits         6176     6175       -1     
- Misses       3145     3146       +1     
Impacted Files Coverage Δ
bentoml/frameworks/tensorflow.py 81.90% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df11494...4bb411e. Read the comment docs.

@bojiang bojiang merged commit 67af403 into bentoml:master Dec 2, 2020
@bojiang bojiang deleted the ci3 branch December 2, 2020 09:36
@bojiang bojiang linked an issue Dec 2, 2020 that may be closed by this pull request
uhbuhb pushed a commit to MLH-Fellowship/BentoML that referenced this pull request Feb 17, 2021
* [CI]add integration test for tf1

* add docs

* fix
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* [CI]add integration test for tf1

* add docs

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST/CI] Add tests covering TensorflowSavedModelArtifact
1 participant