Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test]Make yatai service integration test less flaky #1298

Merged
merged 7 commits into from
Dec 4, 2020

Conversation

yubozhao
Copy link
Contributor

@yubozhao yubozhao commented Dec 4, 2020

Description

Skip the Postgres + local storage yatai service integration for now, because it is very flaky with Github Action CI

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1298 (281c199) into master (ba0b9eb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1298   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files         144      144           
  Lines        9329     9329           
=======================================
  Hits         6189     6189           
  Misses       3140     3140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0b9eb...281c199. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Dec 4, 2020

Hello @yubozhao, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2020-12-04 01:02:41 UTC

@yubozhao yubozhao marked this pull request as ready for review December 4, 2020 01:14
@yubozhao yubozhao merged commit c6ccc55 into bentoml:master Dec 4, 2020
uhbuhb pushed a commit to MLH-Fellowship/BentoML that referenced this pull request Feb 17, 2021
Skipping Yatai service postgres+local fs test, because of how flaky it is on Github CI
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
Skipping Yatai service postgres+local fs test, because of how flaky it is on Github CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants