Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style] opt integration tests #1299

Merged
merged 6 commits into from
Dec 4, 2020
Merged

[Style] opt integration tests #1299

merged 6 commits into from
Dec 4, 2020

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Dec 4, 2020

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Dec 4, 2020 •
edited

Codecov Report

Merging #1299 (56ee076) into master (d00be30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1299   +/-   ##
=======================================
  Coverage   67.27%   67.27%           
=======================================
  Files         144      144           
  Lines        9310     9310           
=======================================
  Hits         6263     6263           
  Misses       3047     3047

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00be30...56ee076. Read the comment docs.

@bojiang bojiang merged commit 45519f6 into bentoml:master Dec 4, 2020
@bojiang bojiang deleted the dev4 branch December 4, 2020 09:18
uhbuhb pushed a commit to MLH-Fellowship/BentoML that referenced this pull request Feb 17, 2021
@bojiang @uhbuhb
[Style] opt integration tests (bentoml#1299)
a3a81e9 
* [Style] opt integration tests

* fix

* fix

* test

* rm __init__

* fic
bojiang
bojiang commented Jun 9, 2021
View reviewed changes
tests/integration/utils.py
with bentoml.utils.reserve_free_port() as port:
pass
if enable_microbatch:
command_args = "--enable-microbatch --workers 1 --mb-max-batch-size 2048"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 2048 here?

aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
@bojiang
[Style] opt integration tests (bentoml#1299)
79d11ba 
* [Style] opt integration tests

* fix

* fix

* test

* rm __init__

* fic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bojiang