New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: YataiService Store Abstraction #1541
Conversation
Hello @jackyzha0, Thanks for updating this PR. There are currently no PEP 8 issues detected in this PR. Cheers! 🍻 Comment last updated at 2021-03-26 22:20:11 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
+ Coverage 68.85% 68.94% +0.08%
==========================================
Files 152 153 +1
Lines 10188 10210 +22
==========================================
+ Hits 7015 7039 +24
+ Misses 3173 3171 -2
Continue to review full report at Codecov.
|
* fix: makefile sphinx deps * docs: added batch_serving docs and linked to it in quickstart * refactor database operations into db class * remove old db code * migrate store related functionality to yatai/db/stores module * makefile + sources typo * refactor to static classes * finish static refactor * fix yatai_service_impl * fix bad patch in test_usage_stats * patch metadatastore property naming bug * lint + format * more lint + fmt * lint + format (again)
Description
First part of #1540, does the base abstraction for existing YataiService stores so that all session creation is handled by the YataiService implementation rather than within the stores itself. This way, we can add the lock acquisition straight into
yatai_service_impl.py
.New module structure:
How Has This Been Tested?
Types of changes
Component(s) if applicable
Checklist:
./dev/format.sh
and./dev/lint.sh
script have passed(instructions).