Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BentoML configuration base #158

Merged
merged 8 commits into from Jun 8, 2019
Merged

BentoML configuration base #158

merged 8 commits into from Jun 8, 2019

Conversation

parano
Copy link
Member

@parano parano commented Jun 8, 2019

  • implementation of python configparser and env var based configuration
  • added apiserver config as an example

Breaking change:

  • changed home folder from ~/.bentoml to ~/bentoml

@parano parano requested a review from yubozhao June 8, 2019 10:30
@codecov-io
Copy link

Codecov Report

Merging #158 into master will increase coverage by 0.4%.
The diff coverage is 71.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #158     +/-   ##
=========================================
+ Coverage   60.98%   61.39%   +0.4%     
=========================================
  Files          48       49      +1     
  Lines        1879     1971     +92     
=========================================
+ Hits         1146     1210     +64     
- Misses        733      761     +28
Impacted Files Coverage Δ
bentoml/server/gunicorn_server.py 63.15% <100%> (ø) ⬆️
bentoml/deployment/sagemaker/__init__.py 20.51% <100%> (ø) ⬆️
bentoml/archive/loader.py 83.33% <100%> (ø) ⬆️
bentoml/__init__.py 100% <100%> (ø) ⬆️
bentoml/cli/__init__.py 43.92% <100%> (ø) ⬆️
bentoml/exceptions.py 100% <100%> (ø)
bentoml/archive/py_module_utils.py 91.13% <100%> (ø) ⬆️
bentoml/deployment/serverless/__init__.py 22.4% <100%> (ø) ⬆️
bentoml/service.py 87.73% <100%> (ø) ⬆️
bentoml/handlers/image_handler.py 57.81% <100%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55293e...0a6d03c. Read the comment docs.

@parano parano merged commit 78a0526 into master Jun 8, 2019
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* implementation of python configparser and env var based configuration

* added apiserver config as an example

* Breaking change: changed home folder from ~/.bentoml to ~/bentoml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants