-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve logging format and configurability #2298
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 47.64% 47.59% -0.06%
==========================================
Files 105 105
Lines 8196 8205 +9
==========================================
Hits 3905 3905
- Misses 4291 4300 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
middlewares.append( | ||
Middleware( | ||
AccessLogMiddleware, | ||
has_request_content_length=access_log_config.request_content_length.get(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: renaming has_
to log_
? e.g. from has_request_content_length
to log_request_content_length
feel free to do that in future logging related PR if you think that makes sense, merging now!
* Fix logging related issues. * Add access logging configuraiton. Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
* Fix logging related issues. * Add access logging configuraiton.
Description
Improve service and access logging format and configurability.
api_server
andrunners
.sampled
key value pair to logging0
or1
instead ofFalse
orTrue
.Motivation and Context
How Has This Been Tested?
Checklist:
make format
andmake lint
script have passed(instructions).